Conversation
varkey98
requested review from
prodion23,
rags0908,
shashank11p,
t-santoshsahu,
thugrock7 and
tim-mwangi
tim-mwangi
approved these changes
Aug 11, 2025
t-santoshsahu
approved these changes
Aug 11, 2025
varkey98
commented
Aug 12, 2025
| ) | ||
| c += fmt.Sprintf(" x.%s = %s(%s_value[rawVal])\n", fieldName, namedType.Name(), namedType.Name()) | ||
| c += fmt.Sprintf(" } else if x.%s == %s(0) && defaultValues != nil && defaultValues.%s != %s(0) {\n", fieldName, fieldName, fieldName, fieldName) | ||
| c += fmt.Sprintf(" } else if x.%s == %s(0) && defaultValues != nil && defaultValues.%s != %s(0) {\n", fieldName, namedType.Name(), fieldName, namedType.Name()) |
Contributor
Author
There was a problem hiding this comment.
fixing code gen for enums
thugrock7
approved these changes
Aug 12, 2025
tim-mwangi
approved these changes
Aug 12, 2025
shashank11p
reviewed
Aug 13, 2025
| | TA_ENABLED | When `false`, disables the agent | | ||
| | TA_TELEMETRY_STARTUP_SPAN_ENABLED | When `true`, an internal span is created and exported when the agent is initialized and started. It's useful to denote when the application the agent is in started. | | ||
| | TA_TELEMETRY_METRICS_ENABLED | Whether to capture metrics or not. The metrics will be otel go metrics. See https://github.com/open-telemetry/opentelemetry-go/tree/main/metric | | ||
| | TA_TELEMETRY_LOGS_ENABLED | When true, logs from the agent will be exported to Traceable Platform Agent via Opentelemetry Logs pipeline. Reporting config is shared with the Traces pipeline. | |
Contributor
There was a problem hiding this comment.
I guess this is not updated with your latest config?
Contributor
Author
There was a problem hiding this comment.
Its updated, we dont generate env vars for enum fields in this code for some reason
tim-mwangi
approved these changes
Aug 13, 2025
varkey98
added a commit
that referenced
this pull request
Sep 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.