Skip to content

Trying to implement the new donation form WIP#114

Closed
furilo wants to merge 1 commit into67-donation-ui-improvementfrom
67-recurring-donations-implementation
Closed

Trying to implement the new donation form WIP#114
furilo wants to merge 1 commit into67-donation-ui-improvementfrom
67-recurring-donations-implementation

Conversation

@furilo
Copy link
Member

@furilo furilo commented Mar 6, 2015

@ferblape I tried to implement @nobuti's form but I think I have the same difficulties as him ;)

  • I don't know how we should handle recurring donations. I guess we should create a new recurring_donation and from there normal donations are created. But please help ;)
  • When you edit a donation, or are creating a donation from a project's page, the project name is selected in the form, but its not being shown at first (if you click then you can see that the correct value is selected. Probably this is more a frontend issue. So maybe @nobuti can you take a look?
  • If you try to create a donation from a project's page or edit, creation/update throws some error. But don't have a clue how to solve it :/

On the other hand, the new css structure looks great, so I think we would ready to merge.

Sorry for so many flecos.

@ferblape ferblape self-assigned this Mar 9, 2015
@furilo furilo mentioned this pull request Mar 10, 2015
5 tasks
@furilo
Copy link
Member Author

furilo commented Mar 16, 2015

We can get rid of this PR right?

@ferblape
Copy link

Yes!

On Mon, Mar 16, 2015 at 9:55 AM, Álvaro Ortiz notifications@github.com
wrote:

We can get rid of this PR right?


Reply to this email directly or view it on GitHub
#114 (comment).

@furilo furilo closed this Mar 16, 2015
@furilo furilo deleted the 67-recurring-donations-implementation branch March 16, 2015 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants