Replace implicit sdk-evm side-effect registration with explicit init#71
Merged
Replace implicit sdk-evm side-effect registration with explicit init#71
Conversation
…h explicit registerEvmSdk() init Move top-level auto-registration out of sdk-evm index.ts into an exported idempotent registerEvmSdk() function. Call it once at client-side app startup in _app.js and remove bare side-effect imports from createHTLCClient.ts, useHTLCWriteClient.ts, and evm.ts. Add vitest tests covering registration, idempotency, and deriveKeyFromWallet wiring. Update registry error messages and add sdk-evm README documenting the required initialization step. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@train-protocol/sdk-evminto an exported, idempotentregisterEvmSdk()functionregisterEvmSdk()once at client-side app startup in_app.js(guarded bytypeof window !== 'undefined')import '@train-protocol/sdk-evm'side-effect imports fromcreateHTLCClient.ts,useHTLCWriteClient.ts, andevm.tscreateHTLCClient, andderiveKeyFromWalletwiring"sideEffects": falsein sdk-evmpackage.jsonfor proper tree-shakingregisterEvmSdk()and adds sdk-evm READMETest plan
pnpm --filter @train-protocol/sdk check:typespassespnpm --filter @train-protocol/sdk-evm check:typespassespnpm --filter @train-protocol/sdk-evm testpasses (5/5)pnpm buildcompiles all packages and app successfullyimport '@train-protocol/sdk-evm'side-effect-only imports🤖 Generated with Claude Code