Skip to content

initial bulk file generator version#373

Merged
StuartFerguson merged 2 commits intomasterfrom
task/#372_bulk_file_generator
Apr 23, 2026
Merged

initial bulk file generator version#373
StuartFerguson merged 2 commits intomasterfrom
task/#372_bulk_file_generator

Conversation

@StuartFerguson
Copy link
Copy Markdown
Member

No description provided.

@StuartFerguson StuartFerguson added the task Tasks and work items label Apr 23, 2026
@StuartFerguson StuartFerguson linked an issue Apr 23, 2026 that may be closed by this pull request
@codacy-production
Copy link
Copy Markdown

codacy-production Bot commented Apr 23, 2026

Not up to standards ⛔

🔴 Issues 43 medium

Alerts:
⚠ 43 issues (≤ 0 issues of at least medium severity)

Results:
43 new issues

Category Results
BestPractice 30 medium
Complexity 12 medium
Performance 1 medium

View in Codacy

🟢 Metrics 265 complexity · 4 duplication

Metric Results
Complexity 265
Duplication 4

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@StuartFerguson
Copy link
Copy Markdown
Member Author

@copilot can you have a look throguh the codacy issues and see if any are quick simple fixes, if they are more involved then leave these as jobs will be created

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 23, 2026

@copilot can you have a look throguh the codacy issues and see if any are quick simple fixes, if they are more involved then leave these as jobs will be created

Reviewed the Codacy issues and applied the quick/simple fixes in commit 2198b2e:

Performance (1 fix)

  • JsonTransactionFileBuilder.cs: transactions.Sum() was being recomputed inside a LINQ Select for every element (O(n²)). Pre-computed it before the Select to make it O(n).

Best Practice (quick fixes)

  • FileProcessingClient.cs: Removed commented-out TODO line.
  • DelimitedTransactionFileBuilder.cs, Worker.cs, FileProcessingClient.cs: Replaced framework type aliases (String, Boolean, Int32, Decimal) with the correct C# language keywords (string, bool, int, decimal).
  • FileStatusReportService.cs: Removed unnecessary $ string interpolation prefix from three string literals that contained no interpolation expressions.

Left for separate jobs

  • The 12 Complexity (medium) issues — all in long methods (ProcessAsync, ExecuteAsync, GetNextRunUtcAsync, Validate, etc.) that would need meaningful refactoring to reduce cyclomatic complexity.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • app.codacy.com
    • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

@StuartFerguson StuartFerguson merged commit 87b6dcb into master Apr 23, 2026
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

task Tasks and work items

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bulk File Generator for staging

2 participants