Fixed Quantization bug in TransformerLens 3.0#1276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
While reviewing #684, I noticed that for BnB-4bit Mistral:
q_proj.weight, k_proj.weight, v_proj.weight, o_proj.weightare allParams4bitwith dtypetorch.uint8(packed). Bridge picks the first param's dtype as the "compute dtype" and castshidden_statesfrom fp32 to uint8, which clamped all values to [0, 255] and truncated decimals. HF'sMistralAttention.forwardthen runs on this destroyed input and produced gibberish.By ensuring this type cast on
hidden_statesis not done with integer dtypes, we get bit-precise results when compared against HuggingFace. Also added regression tests that will fail loudly if this cast is ever unintentionally restored for Quantized models.Type of change
Checklist: