You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
DeepSource reviewed changes in the commit range 8de8b21..18b3c1d on this pull request. Below is the summary for the review, and you can see the individual issues we found as review comments.
Administrators can configure which issue categories are reported and cause analysis to be marked as failed when detected. This helps prevent bad and insecure code from being introduced in the codebase. If you're an administrator, you can modify this in the repository's settings.
💡 If you're a repository administrator, you can configure the quality gates from the settings.
DeepSource reviewed changes in the commit range afe95c8..18b3c1d on this pull request. Below is the summary for the review, and you can see the individual issues we found as review comments.
Administrators can configure which issue categories are reported and cause analysis to be marked as failed when detected. This helps prevent bad and insecure code from being introduced in the codebase. If you're an administrator, you can modify this in the repository's settings.
DeepSource reviewed changes in the commit range afe95c8..18b3c1d on this pull request. Below is the summary for the review, and you can see the individual issues we found as review comments.
Administrators can configure which issue categories are reported and cause analysis to be marked as failed when detected. This helps prevent bad and insecure code from being introduced in the codebase. If you're an administrator, you can modify this in the repository's settings.
The reason will be displayed to describe this comment to others. Learn more.
Method doesn't use the class instance and could be converted into a static method
The method doesn't use its bound instance. Decorate this method with @staticmethod decorator, so that Python does not have to instantiate a bound method for every instance of this class thereby saving memory and computation. Read more about staticmethods here.
The reason will be displayed to describe this comment to others. Learn more.
Raising NotImplementedType while only classes or instances are allowed
Raising objects other than a class, an instance or a string can cause a TypeError.
There can be cases where the value being raised is dynamically set. One common example is initially setting the value to None and assigning other objects based on a condition. Doing so can affect readability and is generally not recommended. In such cases, either re-write the block or ignore the issue for this file.
The reason will be displayed to describe this comment to others. Learn more.
raise NotImplemented causes TypeError at runtime
The code raises NotImplemented, which is a special singleton value, not an exception. This will cause a TypeError to be raised at runtime, which can be misleading and obscure the developer's intent.
Replace NotImplemented with NotImplementedError() to correctly signal that a method is abstract.
The reason will be displayed to describe this comment to others. Learn more.
NotImplemented constant raised instead of NotImplementedError exception
The code raises NotImplemented, which is a special singleton value used in rich comparison methods, not an exception. Attempting to raise it will result in a TypeError at runtime.
To indicate that an interface method must be implemented by subclasses, NotImplementedError should be raised instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.