add: nubia red magic 6 series udfps/fod#5
Merged
phhusson merged 3 commits intoTrebleDroid:android-14.0.0_r2-tdfrom Oct 20, 2023
boydaihungst:android-14.0.0_r2-td
Merged
add: nubia red magic 6 series udfps/fod#5phhusson merged 3 commits intoTrebleDroid:android-14.0.0_r2-tdfrom boydaihungst:android-14.0.0_r2-td
phhusson merged 3 commits intoTrebleDroid:android-14.0.0_r2-tdfrom
boydaihungst:android-14.0.0_r2-td
Conversation
phhusson
reviewed
Oct 20, 2023
| for (Callback cb : mCallbacks) { | ||
| cb.onFingerDown(); | ||
| } | ||
| if(SystemProperties.get("ro.vendor.build.fingerprint").contains("nubia/NX669")) { |
There was a problem hiding this comment.
There should be either some timing or some call back for that 14 event, since that event is supposed to say "hey the green/white circle with HBM is displayed" which should take few frames. Having this timing/callback would probably improve the responsiveness of the FOD.
That being said, I can merge it as-is if you're satisfied with it
Author
There was a problem hiding this comment.
No need to delay for fingerprint white/green circle. After sending the cmd "13" sensor takes 25-200ms to scan the fingerprint. It is enough time for HBM active. In the source code, it only delays 10ms for HBM to be active. It never fails to scan fp for me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will fix fod for Nubia Red Magic 6 series. Tested on my device.
Please merge these PRs first, otherwise, FOD will not work:
fix nubia 6 series (6/6pro/6s/6spro) dt2w + fod hbm device_phh_treble#35(merged: Merge branch 'dev/nubia-6' into android-14.0)Device model: NX669J/NX669S
screen-20231014-125142.2.mp4