Fix AlgorithmDAOTest failure by adding database patch and test data initialization #308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: rvosa <106490+rvosa@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix empty descriptions in AlgorithmDAOTest
Add algorithm reference data to initTreebase.sql
Dec 21, 2025
Contributor
|
@copilot we're still getting this: |
Co-authored-by: rvosa <106490+rvosa@users.noreply.github.com>
Contributor
Author
... The issue was that Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
Add algorithm reference data to initTreebase.sql
Fix AlgorithmDAOTest failure by adding test data initialization
Dec 21, 2025
Contributor
|
@copilot add a patch called patches/0006_add-algorithm-types.sql that is imported by treebase-core/db/schema/init_db_uptodate.pg in the same way as the other imports such that the six algorithm types are created as an integral part of the postgres initialization routine rather than by setting them up for individual tests. |
Co-authored-by: rvosa <106490+rvosa@users.noreply.github.com>
Co-authored-by: rvosa <106490+rvosa@users.noreply.github.com>
Contributor
Author
Created patch |
Copilot
AI
changed the title
Fix AlgorithmDAOTest failure by adding test data initialization
Fix AlgorithmDAOTest failure by adding database patch and test data initialization
Dec 21, 2025
Contributor
|
@copilot new problem: |
Co-authored-by: rvosa <106490+rvosa@users.noreply.github.com>
Contributor
Author
... The duplicate key error was caused by the test's |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix AlgorithmDAOTest Failure
Root Cause
The test
testFinalAllUniqueAlgorithmDescriptionswas failing with "empty descriptions" because the algorithm table had no data during test execution.Solution
Created database patch
0006_add-algorithm-types.sqlthat:init_db_uptodate.pgas part of the PostgreSQL initialization routineAlgorithm types added:
Changes Made
initTreebase.sql(for manual DB setup)0006_add-algorithm-types.sqlfor PostgreSQL initializationinit_db_uptodate.pgto include patches 0006 and 00070006_create-indices.sqlto0007_create-indices.sqlonSetUpBeforeTransaction()method from test (was causing duplicate key errors)Security Summary
No security vulnerabilities detected. All CodeQL checks passed.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.