Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the server and client configurations by adding JWT-based authentication in the Apollo Server setup, updating static file serving logic, and revising the client’s build and Apollo Client configuration.
- Implements JWT verification for API requests through a new getContext function.
- Updates static file serving to check for client dist files using fs.
- Adjusts the Vite build output and simplifies the Apollo Client setup to use cookie-based authentication.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| server/src/server.ts | Adds JWT authentication context and updates static file serving logic |
| client/vite.config.ts | Configures the build output directory |
| client/src/Utils/apolloClient.ts | Adjusts Apollo Client configuration to rely on cookies and removes token auth |
Comments suppressed due to low confidence (1)
client/src/Utils/apolloClient.ts:8
- [nitpick] The previous token-based authentication logic (using an auth link) was removed in favor of sending cookies only; ensure that the backend authentication strategy supports this change and update documentation if necessary.
credentials: 'include', // 🔐 Send cookies with each request
Comment on lines
76
to
+77
| startApolloServer(); | ||
| //commits// No newline at end of file |
There was a problem hiding this comment.
The trailing comment '//commits//' appears extraneous; consider removing it to clean up the production code.
Suggested change
| startApolloServer(); | |
| //commits// | |
| startApolloServer(); |
Jacquilyn-F
approved these changes
May 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.