Skip to content

Develop#71

Merged
Jacquilyn-F merged 11 commits intomainfrom
develop
May 2, 2025
Merged

Develop#71
Jacquilyn-F merged 11 commits intomainfrom
develop

Conversation

@OutsideofemiT
Copy link
Collaborator

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces several improvements including backend middleware modifications, UI enhancements, and adjustments to sound asset configurations in the application. Key changes include:

  • Adding CORS middleware with specific settings to the server.
  • Enhancing logging by including ISO timestamps and updating response objects in the OpenAI API handler.
  • Updating animations, dialog z-index and sound file references, as well as refactoring the answer modal to use a React portal for displaying Dr. Dan’s feedback.

Reviewed Changes

Copilot reviewed 12 out of 14 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
server/src/server.ts Added CORS middleware to allow requests from the frontend.
server/src/routes/api/openai.ts Updated log messages with timestamps and response objects.
client/tailwind.config.js Introduced new scaleIn animation configuration.
client/src/components/ui/dialog.tsx Adjusted DialogContent styling and increased the z-index.
client/src/components/screens/Questions.tsx Preloaded sound assets and updated audio file references.
client/src/components/DanismEvent.tsx Updated sound file references for new audio assets.
client/src/components/AnswerResultModal.tsx Refactored to use a React portal and removed unused properties.
Files not reviewed (2)
  • package.json: Language not supported
  • server/package.json: Language not supported
Comments suppressed due to low confidence (5)

client/src/components/ui/dialog.tsx:38

  • The z-index has been significantly increased from its previous value; verify that this high value does not interfere with other UI layers or modals in the application.
className={cn("fixed z-[9999] p-0 bg-transparent border-none shadow-none w-fit", className)}

server/src/routes/api/openai.ts:50

  • The response now includes a new 'fallback' property which may alter the API contract. Ensure that client consumers are updated to handle this schema change and document it accordingly.
return res.json({ type: 'fallback', question: fallback, fallback: true });

client/src/components/screens/Questions.tsx:102

  • The sound file name was updated from '/audio/Dan_correct/correctStar.wav' to '/audio/Dan_correct/Dan-correct-4.wav'. Confirm that this new filename matches the actual asset to prevent missing resource errors.
'/audio/Dan_correct/Dan-correct-4.wav'

client/src/components/screens/Questions.tsx:109

  • The incorrect audio clip reference has been updated; ensure that the new file '/audio/Dan_incorrect/Dan-incorrect-5.wav' is available and that client logic correctly handles this sound asset.
'/audio/Dan_incorrect/Dan-incorrect-5.wav'

client/src/components/DanismEvent.tsx:21

  • A new sound file '/audio/Dan_correct/Dan-5inarow.wav' was added; please verify that the file exists and its naming is consistent with other asset files to avoid runtime issues.
'/audio/Dan_correct/Dan-5inarow.wav',

Comment on lines 55 to +56
export default AnswerResultModal;
//commiting" No newline at end of file
Copy link

Copilot AI May 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a stray comment at the end of the file that appears to be unintentional. It is recommended to remove this comment to clean up the code.

Suggested change
export default AnswerResultModal;
//commiting"
export default AnswerResultModal;

Copilot uses AI. Check for mistakes.
@Jacquilyn-F Jacquilyn-F merged commit 23da71a into main May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants