Port Core/Networking: Fixed unsafe access to _worldSession member in WorldSocket #14474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
the commit should be generated with git cherry-pick command, including the source commit reference (-x parameter should do it) |
Contributor
Author
|
Fix'd |
ariel-
force-pushed
the
bed88e0
branch
2 times, most recently
from
ce62784 to
2acbd49
Compare
…Socket (cherry picked from commit bed88e0) Conflicts: src/server/game/Server/WorldSession.cpp src/server/game/Server/WorldSocket.cpp src/server/game/Server/WorldSocket.h
Member
|
add 3da0f7e |
…to be kicked for overspeed pings (cherry picked from commit 3da0f7e)
Member
|
this code keeps being changed in 6.x and these changes are being tracked at #14418 . while we thank you for the effort into submitting a PR, I have to close it because we prefer to deal with cherry-picks on our own . It might be better also to merge these changes when they are stable on 6.x |
Shauren
added a commit
that referenced
this pull request
Apr 4, 2015
…Socket (cherry picked from commit bed88e0) Core/Networking: Fixed deadlock in HandlePing if the client is about to be kicked for overspeed pings (cherry picked from commit 3da0f7e) Core/Networking: Cleanup CloseSocket calls from read failures in WorldSocket (cherry picked from commit 18343a7) Conflicts: src/server/game/Server/WorldSocket.cpp Ref #14474
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.