Skip to content

MPLv2#6

Merged
chorrell merged 7 commits intomasterfrom
MPLv2
Apr 12, 2016
Merged

MPLv2#6
chorrell merged 7 commits intomasterfrom
MPLv2

Conversation

@chorrell
Copy link
Copy Markdown
Contributor

@dwlf
Copy link
Copy Markdown

dwlf commented Apr 12, 2016

As MPL is a "per file" license the license header should be in each file.

"To apply the Mozilla Public License to software that you have written, add the header from Exhibit A of the license to each source code file in your project."
https://www.mozilla.org/en-US/MPL/2.0/FAQ/

@misterbisson
Copy link
Copy Markdown

Thank you!

🏡 🚶

@tgross
Copy link
Copy Markdown
Contributor

tgross commented Apr 12, 2016

It would be really nice if this library had a makefile that set up the workspace properly... it's unclear to me how the github.com/joyent/gocommon/testing package works with this library given just the contents of this repo. (I recognize this is out of scope for a PR intended just to fix the licensing)

In any event, @chorrell I tried to run the tests and got a bunch of errors that look related to the setup of the test suite fixtures, but this one looks like it's a legit compilation error:

src/github.com/joyent/gomanta/localservices/manta/service_http_test.go:65: cannot use s.HTTPSuite.Mux (type *httprouter.Router) as type *"net/http".ServeMux in argument to s.service.SetupHTTP

@tgross
Copy link
Copy Markdown
Contributor

tgross commented Apr 12, 2016

this one looks like it's a legit compilation error

@chorrell it looks like I'm getting that against master as well. I think this is safe to merge and then maybe we can circle back to figure out what the test suite story is supposed to be.

@chorrell
Copy link
Copy Markdown
Contributor Author

Cool, thanks for the sanity check @tgross. I'll go ahead an merge and will open a "fix tests" issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update License to MPL2?

4 participants