Add new ftp option #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...dge.Core/Extensions/Microsoft.Extensions.DependencyInjection/IServiceCollectionExtensions.cs
Outdated
Show resolved
Hide resolved
src/CloudFtpBridge.BlazorApp/Shared/FileSystemOptions/SupportedFileSystems.cs
Outdated
Show resolved
Hide resolved
DotJoshJohnson
requested changes
Dec 2, 2021
Member
DotJoshJohnson
left a comment
DotJoshJohnson
left a comment
There was a problem hiding this comment.
I added comments to each file explaining in detail, but in short:
FTPFileSystem should implement the IFileSystem interface. The code from Receive.cs and Send.cs can then be ported to FTPFileSystem as needed. All changes to WorkflowRunner can be reverted as it will use FileSystemActivator to obtain a configured instance of the appropriate IFileSystem implementation.
…gging and works with FileSystemActivator which in turn allows logging in the audit log.
DotJoshJohnson
approved these changes
Dec 6, 2021
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new FTP option utilizing System.Net.FtpWebRequest.
Logging will need added to this option eventually. Currently errors can be viewed while processing runs in debugview.