Update wasm-timer to wasmtimer#202
Merged
eopb merged 4 commits intoTrueLayer:mainfrom Jan 30, 2025
Merged
Conversation
eopb
requested changes
Nov 27, 2024
Member
eopb
left a comment
eopb
left a comment
There was a problem hiding this comment.
Thanks for the PR 🙌
One thing needs to be changed
| retry-policies = "0.4" | ||
| thiserror = "1.0.61" | ||
| tracing = { version = "0.1.26", optional = true } | ||
| wasmtimer = "0.4.1" |
Member
There was a problem hiding this comment.
We need to gate this dependency behind cfg(target_arch = "wasm32") like we did before
|
lgtm, but the change has conflicts now. |
eopb
approved these changes
Jan 23, 2025
Contributor
Author
|
Would you like me to fix the clippy issues? It seems pretty unrelated but I can mash it also into this PR. |
Member
No worries. Clippy can be fixed in another PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Swaps over to wasmtimer, an updated library from wasm-timer which is not maintained.
Closes #199
See here for fork: google/tarpc#388