Adding support for aasvg graphics. #216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding support for aasvg graphics/diagrams. Example: ```aasvg +--------+ .-------. +--------+ | Server +-->+ Message +--->+ Client | +--------+ '-------' +--------+ ``` Further: some minor syntax and grammar/text fixes. Signed-off-by: Michael Eckel <michael.eckel@sit.fraunhofer.de>
Closed
chrisfenner
approved these changes
Mar 11, 2025
Member
chrisfenner
left a comment
chrisfenner
left a comment
There was a problem hiding this comment.
This is super cool. One nit: could you add an example of this to the guide.tcg as a mini-test and so that people can see how to use it and how it looks?
Signed-off-by: Michael Eckel <michael.eckel@sit.fraunhofer.de>
Contributor
Author
Oh, thanks, good point. Done. |
Member
|
We got this error again: ERROR: failed to solve: failed to push ghcr.io/trustedcomputinggroup/pandoc_test: unexpected status from POST request to https://ghcr.io/v2/trustedcomputinggroup/pandoc_test/blobs/uploads/: 403 Forbidden I don't think it's related to the change, so I'll merge it anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for aasvg graphics/diagrams.
Example:
Further: some minor syntax and grammar/text fixes.
Fixes #215 and fixes #207 (PR #208 can be considered obsolete, I think).