Skip to content

Fixed broken table headers#1043

Merged
weylandswart merged 1 commit into
mainfrom
weyland-des-1319-table-headings-render-completely-black
Apr 6, 2026
Merged

Fixed broken table headers#1043
weylandswart merged 1 commit into
mainfrom
weyland-des-1319-table-headings-render-completely-black

Conversation

@weylandswart
Copy link
Copy Markdown
Contributor

Closes https://linear.app/ghost/issue/DES-1319/table-headings-render-completely-black

The Tailwind v4 upgrade broke colormod. Similar fix to the one from #1040 but wanted to preserve the variable adjustments.

Before After
Screenshot 2026-04-06 at 16 24 24 Screenshot 2026-04-06 at 16 23 51

Closes https://linear.app/ghost/issue/DES-1319/table-headings-render-completely-black

The Tailwind v4 upgrade broke colormod. Similar fix to the one from #1040.
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 6, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 0ffc4fd5-f0fb-4dce-80c7-a5ab609bef1e

📥 Commits

Reviewing files that changed from the base of the PR and between 24e244e and d5970cd.

⛔ Files ignored due to path filters (1)
  • assets/built/screen.css.map is excluded by !**/*.map
📒 Files selected for processing (2)
  • assets/built/screen.css
  • assets/css/screen.css

Walkthrough

Two CSS files are updated with styling refinements. assets/built/screen.css expands the --font-sans font-family stack to include Fira Sans and adjusts dark-mode table styling by changing background and border colors from #131416 to #282b2f across relevant selectors. assets/css/screen.css modifies table styling using color-mod() expressions: light-mode changes replace relative lightness adjustments with absolute values, while dark-mode changes update the color-darkmode lightness parameter from +8% to 17% in both explicit dark-mode and auto-color selectors.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: fixing broken table headers caused by the Tailwind v4 upgrade affecting the colormod function.
Description check ✅ Passed The description is directly related to the changeset, referencing the specific issue (DES-1319), explaining the root cause (Tailwind v4 broke colormod), and providing before/after screenshots demonstrating the fix.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch weyland-des-1319-table-headings-render-completely-black

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@weylandswart weylandswart merged commit 4e93b03 into main Apr 6, 2026
1 check passed
@weylandswart weylandswart deleted the weyland-des-1319-table-headings-render-completely-black branch April 6, 2026 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant