fix #1032: add constants for file open mode#1042
Closed
gms1 wants to merge 2 commits intoTryGhost:masterfrom
Closed
fix #1032: add constants for file open mode#1042gms1 wants to merge 2 commits intoTryGhost:masterfrom
gms1 wants to merge 2 commits intoTryGhost:masterfrom
Conversation
Contributor
Author
|
tests have passed and the broken Travis CI build has nothing to do with this PR: |
Contributor
Author
|
sorry, SQLITE_OPEN_MEMORY seems to be not available |
Contributor
Author
|
all build errors related to this PR have been fixed, remaining ones are unrelated: make: clang-3.5: Command not found#1012.10: ./scripts/build_against_node.sh: line 20: cpp-coveralls: command not found#1012.14: Updating Homebrew...
==> Downloading https://homebrew.bintray.com/bottles-portable-ruby/portable-ruby-2.3.7.leopard_64.bottle.tar.gz
############################################################### 88.4%######################################################################## 100.0%
==> Pouring portable-ruby-2.3.7.leopard_64.bottle.tar.gz
==>Homebrew is run entirely by unpaid volunteers. Please consider donating:
https://github.com/Homebrew/brew#donations
No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received
The build has been terminated#1012.20: $ sudo -E apt-get -yq --no-install-suggests --no-install-recommends $(travis_apt_get_options) install clang-3.5
...
The following packages have unmet dependencies:
clang-3.5 : Depends: libclang1-3.5 (= 1:3.5~svn217304-1~exp1) but it is not going to be installed
Depends: libllvm3.5 but it is not going to be installed
Depends: libstdc++-4.8-dev but it is not installable
Depends: libgcc-4.8-dev but it is not installable
Depends: libobjc-4.8-dev but it is not installable
Depends: libclang-common-3.5-dev (= 1:3.5~svn217304-1~exp1) but it is not going to be installed
E: Unable to correct problems, you have held broken packages. |
Contributor
Author
|
replaced by #1078 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR only propagates some missing constants for file open to JavaScript:
Flags For File Open Operations
please see #1032 for a description of possible use cases