Merged
Conversation
…s to app categories update
modified add_build_to_beta_group because it does not return a BetaGroup object modified modify and create app_store_version functions
Tuni
reviewed
Dec 8, 2020
appstoreconnect/api.py
Outdated
| PATCH = 3 | ||
| DELETE = 4 | ||
|
|
||
| class AppStoreState(Enum): |
Owner
There was a problem hiding this comment.
Je me demande si cette classe a sa place ici. Ca a aucune utilité à la lib il me semble, c'est utilisé pour notre logique à nous. T'en penses quoi ?
Collaborator
Author
There was a problem hiding this comment.
Je suppose que dans notre usage, la suppression d'élément ne doit se faire à aucun moment sans l'intervention humaine. C'est pas forcément la bonne idée d'automatiser la suppression. On en n'a pas besoin. Mais dans la lib la méthode delete ne représente aucun danger, on l'appelle nulle part .
deleted AppStoreState class
…ly ) added copyroth parameters form create and modify app store version functions
Change localisation of functions
…ion_localization parameters - add reference for list_app_store_version_localizations and list_app_store_info_localizations
Refactor app info localization
App info localization
fix coma bug in AppStoreVersionLocalization class attributes list
…ctor the name of function to lowercase string
Age ratingrefacto
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.