Open
Conversation
Contributor
|
Thanks very much. I've changed the data extraction functions so that they can get either precipitation or air temps. I'll ask Kostas to review them and will use the data to check your plotting functions. |
Contributor
|
Hi Heba |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Kevin,
I have applied the suggested modifications. Yet I am not sure if I faked the map plotting correctly in the Vignette. Please feel free to adjust that if you like. If you also change the name of the functions as you mentioned, this update will need to be reflected in the Vignette.
Please let me know if anything else needs to be modified.
Thanks very much for your guidance!
Best regards,
Heba