Skip to content

Plotting functions changes#22

Open
HebaMSA wants to merge 2 commits intoTycheLab:mainfrom
HebaMSA:ha_working
Open

Plotting functions changes#22
HebaMSA wants to merge 2 commits intoTycheLab:mainfrom
HebaMSA:ha_working

Conversation

@HebaMSA
Copy link
Copy Markdown
Contributor

@HebaMSA HebaMSA commented Apr 15, 2025

Hi Kevin,

I have applied the suggested modifications. Yet I am not sure if I faked the map plotting correctly in the Vignette. Please feel free to adjust that if you like. If you also change the name of the functions as you mentioned, this update will need to be reflected in the Vignette.

Please let me know if anything else needs to be modified.

Thanks very much for your guidance!

Best regards,
Heba

@KevinShook
Copy link
Copy Markdown
Contributor

Thanks very much. I've changed the data extraction functions so that they can get either precipitation or air temps. I'll ask Kostas to review them and will use the data to check your plotting functions.

@KevinShook
Copy link
Copy Markdown
Contributor

Hi Heba
Kostas approved merging my branch with the new data extraction functions. Unfortunately, that means that your branch is now out of date, and will have to be modified to fix all the conflicts shown above. It also means that the vignette will have to be updated with the new functions.
Let me know if you need help with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants