fixes https://github.com/TypeStrong/ts-loader/issues/1014#1015
Merged
johnnyreilly merged 3 commits intoTypeStrong:masterfrom Sep 20, 2019
Merged
fixes https://github.com/TypeStrong/ts-loader/issues/1014#1015johnnyreilly merged 3 commits intoTypeStrong:masterfrom
johnnyreilly merged 3 commits intoTypeStrong:masterfrom
Conversation
| } | ||
| if ( | ||
| (configFile.options.declaration || configFile.options.composite) && | ||
| (instance.compiler as any).hasTSFileExtension(inputFileName) |
Contributor
There was a problem hiding this comment.
You want to add this part to getEmitOutput to return [] early even before getting program rather than here.
src/instances.ts
Outdated
| } | ||
|
|
||
| export function getEmitOutput(instance: TSInstance, filePath: string) { | ||
| if (fileExtensionIs(filePath, typescript.Extension.Dts)) { |
Contributor
There was a problem hiding this comment.
Sorry missed this earlier but for extension use instance.compiler.Extension.Dts typescript is used only for types for tsloader code.. The compiler = typescript of the compilation
Contributor
Author
There was a problem hiding this comment.
done, thanks for your time
sheetalkamat
approved these changes
Sep 20, 2019
Member
|
This looks great! |
Member
|
Build is only failing because #1016 isn't merged yet - merging this; will merge the other subsequently |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
it seems that ts-loader is trying to emit declaration files for a declaration file, this causes typescript's getOutputDeclarationFileName throw an error