Skip to content

fix links to heading IDs#1044

Closed
sheonhan wants to merge 1 commit intoTypeStrong:masterfrom
sheonhan:bugfix/links-to-heading-ids
Closed

fix links to heading IDs#1044
sheonhan wants to merge 1 commit intoTypeStrong:masterfrom
sheonhan:bugfix/links-to-heading-ids

Conversation

@sheonhan
Copy link

In the Table of Contents, links to heading IDs had superfluous underscores, so the links weren't jumping to corresponding sections in the README.

@johnnyreilly
Copy link
Member

Thanks for this! This arrived with #1032

The tricky thing is that the Table of Contents isn't hand cranked but generated using github-markdown-toc. If we fix it manually then presumably the issue will present again next time the TOC is regenerated.

Is there another way we could fix this "at source" as it were? cc @jsjoeio

@jsjoeio
Copy link
Contributor

jsjoeio commented Dec 22, 2019

Thanks for catching this @sheonhan, and @johnnyreilly for tagging me.

Apologies - when I added it in, I didn't test every link. The majority were working so I thought it was good. I'll take a look to see what I can do to fix the underscores in the unique headings.

@sheonhan
Copy link
Author

Thanks for such a quick response, everyone! I'll close this PR for now.

@sheonhan sheonhan closed this Dec 22, 2019
@sheonhan sheonhan deleted the bugfix/links-to-heading-ids branch December 22, 2019 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants