fix links to heading IDs#1044
Closed
sheonhan wants to merge 1 commit intoTypeStrong:masterfrom
sheonhan:bugfix/links-to-heading-ids
Closed
fix links to heading IDs#1044sheonhan wants to merge 1 commit intoTypeStrong:masterfrom sheonhan:bugfix/links-to-heading-ids
sheonhan wants to merge 1 commit intoTypeStrong:masterfrom
sheonhan:bugfix/links-to-heading-ids
Conversation
Member
|
Thanks for this! This arrived with #1032 The tricky thing is that the Table of Contents isn't hand cranked but generated using Is there another way we could fix this "at source" as it were? cc @jsjoeio |
Contributor
|
Thanks for catching this @sheonhan, and @johnnyreilly for tagging me. Apologies - when I added it in, I didn't test every link. The majority were working so I thought it was good. I'll take a look to see what I can do to fix the underscores in the unique headings. |
Author
|
Thanks for such a quick response, everyone! I'll close this PR for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the Table of Contents, links to heading IDs had superfluous underscores, so the links weren't jumping to corresponding sections in the README.