Skip to content

fix: change others approved label#14

Merged
typeslint-cli[bot] merged 1 commit intoTypeslint:mainfrom
HarunamiYaki:main
Jan 15, 2023
Merged

fix: change others approved label#14
typeslint-cli[bot] merged 1 commit intoTypeslint:mainfrom
HarunamiYaki:main

Conversation

@HarunamiYaki
Copy link
Copy Markdown
Member

Describe the bug
Change contributor label instead of getting codeowners approved

To Reproduce
Steps to reproduce the behavior:

  1. Fork the repository and make a change
  2. Create a pull request as a member it needs to be reviewed by a member, contributor, or collaborator.
  3. Approve code review

Expected behavior
API set Others Approve label to PRs

change contributor label instead getting codeowners approved
Copy link
Copy Markdown
Member

@Muunatic Muunatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks @HarunamiYaki

Comment thread src/index.ts
Copy link
Copy Markdown
Contributor

@typeslint-cli typeslint-cli Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HarunamiYaki your pull request has been approved by @Muunatic, please type Ready to merge for merging

@typeslint-cli typeslint-cli Bot added the Approved Approved PRs label Jan 15, 2023
@HarunamiYaki
Copy link
Copy Markdown
Member Author

Ready to merge

@typeslint-cli typeslint-cli Bot merged commit 25e1604 into Typeslint:main Jan 15, 2023
@typeslint-cli
Copy link
Copy Markdown
Contributor

typeslint-cli Bot commented Jan 15, 2023

Merged by HarunamiYaki!

@Muunatic Muunatic added this to the v3.0.0 milestone Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Approved PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants