Skip to content

feat: check PRs type#15

Merged
typeslint-cli[bot] merged 1 commit intoTypeslint:mainfrom
HarunamiYaki:main
Jan 18, 2023
Merged

feat: check PRs type#15
typeslint-cli[bot] merged 1 commit intoTypeslint:mainfrom
HarunamiYaki:main

Conversation

@HarunamiYaki
Copy link
Copy Markdown
Member

@HarunamiYaki HarunamiYaki commented Jan 18, 2023

Changes

check PRs type is "User" or "Bot", give a different statement for each value

switch (payload) {
    case value:
        break;
    default:
        break;
}

@typeslint-cli
Copy link
Copy Markdown
Contributor

typeslint-cli Bot commented Jan 18, 2023

Hello @HarunamiYaki Thank you for submitting Pull Request, please wait for next notification after we review your Pull Request

@typeslint-cli typeslint-cli Bot added the Pending Unread Issues/PRs label Jan 18, 2023
@HarunamiYaki
Copy link
Copy Markdown
Member Author

HarunamiYaki commented Jan 18, 2023

some lines are not given semicolons, should I add additional rules in eslint? @Muunatic

@Muunatic
Copy link
Copy Markdown
Member

Muunatic commented Jan 18, 2023

there are several rules that I want to add later, so no need to add additional rules for now

@HarunamiYaki HarunamiYaki marked this pull request as ready for review January 18, 2023 22:42
@HarunamiYaki
Copy link
Copy Markdown
Member Author

HarunamiYaki commented Jan 18, 2023

Ready for review @Muunatic

Muunatic
Muunatic approved these changes Jan 18, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@Muunatic Muunatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

typeslint-cli[bot]
typeslint-cli Bot reviewed Jan 18, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@typeslint-cli typeslint-cli Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HarunamiYaki your pull request has been approved by @Muunatic, please type Ready to merge for merging

@typeslint-cli typeslint-cli Bot added Approved Approved PRs and removed Pending Unread Issues/PRs labels Jan 18, 2023
@HarunamiYaki
Copy link
Copy Markdown
Member Author

HarunamiYaki commented Jan 18, 2023

Ready to merge

@typeslint-cli typeslint-cli Bot merged commit 6104e7b into Typeslint:main Jan 18, 2023
@typeslint-cli
Copy link
Copy Markdown
Contributor

typeslint-cli Bot commented Jan 18, 2023

Merged by HarunamiYaki!

@Muunatic Muunatic added this to the v3.0.0 milestone Nov 7, 2023
@Muunatic Muunatic mentioned this pull request Jan 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@typeslint-cli typeslint-cli[bot] typeslint-cli[bot] left review comments

@Muunatic Muunatic Muunatic approved these changes

Assignees

No one assigned

Labels

Approved Approved PRs

Projects

None yet

Milestone

v3.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@HarunamiYaki @Muunatic