Skip to content

refactor: get sha from object#17

Merged
typeslint-cli[bot] merged 1 commit intoTypeslint:developmentfrom
HarunamiYaki:main
Mar 29, 2023
Merged

refactor: get sha from object#17
typeslint-cli[bot] merged 1 commit intoTypeslint:developmentfrom
HarunamiYaki:main

Conversation

@HarunamiYaki
Copy link
Copy Markdown
Member

Please describe the changes this PR makes and why it should be merged:
get sha from object and avoid Explicit Any for ESLint

if ("sha" in res.data)

Reference:
https://github.com/Muunatic/github-AutoResponse/blob/a88ca5e49353b4a1d1eefa17bc6d288c64b33c15/src/index.ts#L80
https://github.com/Muunatic/github-AutoResponse/blob/a88ca5e49353b4a1d1eefa17bc6d288c64b33c15/src/index.ts#L81

@HarunamiYaki HarunamiYaki requested a review from Muunatic as a code owner March 26, 2023 09:15
@typeslint-cli
Copy link
Copy Markdown
Contributor

typeslint-cli Bot commented Mar 26, 2023

Hello @HarunamiYaki Thank you for submitting Pull Request, please wait for next notification after we review your Pull Request

@typeslint-cli typeslint-cli Bot added Core Pending Unread Issues/PRs labels Mar 26, 2023
Copy link
Copy Markdown
Member

@Muunatic Muunatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Copy Markdown
Contributor

@typeslint-cli typeslint-cli Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HarunamiYaki your pull request has been approved by @Muunatic, please type Ready to merge for merging

@typeslint-cli typeslint-cli Bot added Approved Approved PRs and removed Pending Unread Issues/PRs labels Mar 28, 2023
@HarunamiYaki
Copy link
Copy Markdown
Member Author

Ready to merge

@typeslint-cli typeslint-cli Bot merged commit 16517fa into Typeslint:development Mar 29, 2023
@typeslint-cli
Copy link
Copy Markdown
Contributor

typeslint-cli Bot commented Mar 29, 2023

Merged by HarunamiYaki!

@Muunatic Muunatic added this to the v3.0.0 milestone Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Approved PRs Core

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants