Skip to content

fix: inaccessible pull_request number in workflow_run #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
typeslint-cli merged 3 commits into from
Dec 5, 2023
Merged

fix: inaccessible pull_request number in workflow_run #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5164829
style: change to checkUserCI
Muunatic Nov 20, 2023
87ad7bc
fix: inaccessible pull_request number in workflow_run
Muunatic Nov 20, 2023
ac81168
refactor: get pull request number by head_sha
Muunatic Nov 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
95 changes: 52 additions & 43 deletions src/class/workflowCheck.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import Context from "../index";
import Context, { octokit } from "../index";

/**
* @class
Expand All @@ -9,13 +9,13 @@ export default class WorkflowCheck {

/**
* @private
* @type Context<"issues.closed">
* @type Context<"workflow_run.completed">
*/
private context: Context<"workflow_run.completed">;

/**
* @constructor
* @param {Context<"issues.closed">} context
* @param {Context<"workflow_run.completed">} context
*/
constructor(context: Context<"workflow_run.completed">) {
this.context = context;
Expand Down Expand Up @@ -54,47 +54,56 @@ export default class WorkflowCheck {
* @async
* @returns {Promise<void>}
*/
public async CheckUserCI(): Promise<void> {
if (this.context.payload.workflow_run.conclusion == "success") {
await this.context.octokit.pulls.get({
owner: this.context.payload.repository.owner.login,
repo: this.context.payload.repository.name,
pull_number: this.context.payload.workflow_run.pull_requests[0].number
}).then(async (res) => {
if (res.data.labels.find(a => a.name == "CI Failed")) {
await this.context.octokit.issues.removeLabel(
this.context.issue({
owner: this.context.payload.repository.owner.login,
repo: this.context.payload.repository.name,
issue_number: this.context.payload.workflow_run.pull_requests[0].number,
name: "CI Failed"
})
);
console.log("CI Passed!");
} else {
return;
}
});
} else if (this.context.payload.workflow_run.conclusion == "failure") {
console.log("CI Failure!");
await this.context.octokit.issues.addLabels(
this.context.issue({
owner: this.context.payload.repository.owner.login,
repo: this.context.payload.repository.name,
issue_number: this.context.payload.workflow_run.pull_requests[0].number,
labels: ["CI Failed"]
})
);
await this.context.octokit.issues.createComment(
this.context.issue({
public async checkUserCI(): Promise<void> {
await octokit.rest.pulls.list({
owner: this.context.payload.repository.owner.login,
repo: this.context.payload.repository.name,
head: `${this.context.payload.workflow_run.actor.login}:${this.context.payload.workflow_run.head_branch}`,
state: "open"
}).then(async (res) => {
const prsNumber = res.data.find((a) => a.head.sha === this.context.payload.workflow_run.head_sha)?.number as number;
if (this.context.payload.workflow_run.conclusion == "success") {
await this.context.octokit.pulls.get({
owner: this.context.payload.repository.owner.login,
repo: this.context.payload.repository.name,
issue_number: this.context.payload.workflow_run.pull_requests[0].number,
body: `CI build failed! for more information please review the [logs](${this.context.payload.workflow_run.html_url}).`
})
);
} else {
return;
}
pull_number: prsNumber
}).then(async (res) => {
if (res.data.labels.find(a => a.name == "CI Failed")) {
await this.context.octokit.issues.removeLabel(
this.context.issue({
owner: this.context.payload.repository.owner.login,
repo: this.context.payload.repository.name,
issue_number: prsNumber,
name: "CI Failed"
})
);
console.log("CI Passed!");
} else {
return;
}
});
} else if (this.context.payload.workflow_run.conclusion == "failure") {
console.log("CI Failure!");
await this.context.octokit.issues.addLabels(
this.context.issue({
owner: this.context.payload.repository.owner.login,
repo: this.context.payload.repository.name,
issue_number: prsNumber,
labels: ["CI Failed"]
})
);
await this.context.octokit.issues.createComment(
this.context.issue({
owner: this.context.payload.repository.owner.login,
repo: this.context.payload.repository.name,
issue_number: prsNumber,
body: `CI build failed! for more information please review the [logs](${this.context.payload.workflow_run.html_url}).`
})
);
} else {
return;
}
});
}

}
6 changes: 4 additions & 2 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,12 @@ const octokit = new Octokit({
privateKey: process.env.PRIVATE_KEY,
clientId: process.env.CLIENT_ID,
clientSecret: process.env.CLIENT_SECRET,
installationId: 21573969
installationId: 12345678 // env not working
}
});

module.exports = (app: Probot) => {

app.on("push", async (context): Promise<void> => {
await new Push(context).push();
});
Expand Down Expand Up @@ -92,14 +93,15 @@ module.exports = (app: Probot) => {
app.on("workflow_run.completed", async (context): Promise<void> => {
if (context.payload.workflow_run.event == "pull_request") {
if (context.payload.sender.type == "User") {
await new WorkflowCheck(context).CheckUserCI();
await new WorkflowCheck(context).checkUserCI();
} else {
await new WorkflowCheck(context).checkCI();
}
} else {
return;
}
});

};

setInterval(() => {
Expand Down