Skip to content

refactor: create comment for prs author #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
typeslint-cli merged 1 commit into from
Apr 19, 2024
Merged

refactor: create comment for prs author #63

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 27 additions & 18 deletions src/class/prsSynchronize.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export default class PullRequestSynchronize {
issue_number: this.context.payload.pull_request.number
}).then(async (res) => {
let i: number;
const prsLabels = res.data.find((a) => a.name == "Requested Changes" || a.name == "Approved")?.name;
const prsLabels = res.data.find((a) => a.name === "Requested Changes" || a.name === "Approved")?.name;
if (prsLabels) {
await this.context.octokit.pulls.listReviews({
owner: this.context.payload.repository.owner.login,
Expand All @@ -43,13 +43,13 @@ export default class PullRequestSynchronize {
const reviewersArray: string[] = [];
const tagReviewers: string[] = [];
for (i = 0; i < res.data.length; i++) {
if (res.data[i].user?.type == "User") {
if (res.data[i].user?.type === "User") {
const datastate: string[] = [
"CHANGES_REQUESTED",
"APPROVED"
];
if (res.data[i].state == datastate.find((a) => a == res.data[i].state)) {
if (res.data[i].user?.login != reviewersArray.find((a) => a == res.data[i].user?.login)) {
if (res.data[i].state === datastate.find((a) => a === res.data[i].state)) {
if (res.data[i].user?.login !== reviewersArray.find((a) => a === res.data[i].user?.login)) {
const username: string = res.data[i].user?.login || "";
reviewersArray.push(username);
tagReviewers.push("@" + username);
Expand All @@ -76,19 +76,28 @@ export default class PullRequestSynchronize {
continue;
}
}
await this.context.octokit.issues.createComment(
this.context.issue({
owner: this.context.payload.repository.owner.login,
repo: this.context.payload.repository.name,
issue_number: this.context.payload.pull_request.number,
body: `PING! ${tagReviewers.join(", ")}. The author has pushed new commits since your last review. please review @${this.context.payload.sender.login} new commit before merge, thanks!`
})
);
await this.context.octokit.issues.removeLabel(
this.context.issue({
name: prsLabels
})
);
if (this.context.payload.sender.login === this.context.payload.pull_request.user.login) {
await this.context.octokit.issues.createComment(
this.context.issue({
owner: this.context.payload.repository.owner.login,
repo: this.context.payload.repository.name,
issue_number: this.context.payload.pull_request.number,
body: `PING! ${tagReviewers.join(", ")}. The author has pushed new commits since your last review. please review @${this.context.payload.sender.login} new commit before merge, thanks!`
})
);
await this.context.octokit.issues.removeLabel(
this.context.issue({
name: prsLabels
})
);
} else {
await this.context.octokit.issues.removeLabel(
this.context.issue({
name: prsLabels
})
);
return;
}
});
} else {
return;
Expand Down Expand Up @@ -124,7 +133,7 @@ export default class PullRequestSynchronize {
repo: this.context.payload.repository.name,
issue_number: this.context.payload.pull_request.number
}).then(async (res) => {
if (res.data.find((a) => a.name == "Config Invalid")) {
if (res.data.find((a) => a.name === "Config Invalid")) {
await this.context.octokit.issues.removeLabel(
this.context.issue({
name: "Config Invalid"
Expand Down