Skip to content

feat(prs): tag maintainers for non user prs#69

Merged
typeslint-cli[bot] merged 2 commits intoTypeslint:developmentfrom
Muunatic:development
Sep 12, 2024
Merged

feat(prs): tag maintainers for non user prs#69
typeslint-cli[bot] merged 2 commits intoTypeslint:developmentfrom
Muunatic:development

Conversation

@Muunatic
Copy link
Copy Markdown
Member

@Muunatic Muunatic commented Sep 9, 2024

tag maintainers for non user prs

@typeslint-cli
Copy link
Copy Markdown
Contributor

typeslint-cli Bot commented Sep 9, 2024

Hello @Muunatic Thank you for submitting Pull Request, please wait for next notification after we review your Pull Request

@typeslint-cli typeslint-cli Bot added Pending Unread Issues/PRs lib: Pull Request labels Sep 9, 2024
Copy link
Copy Markdown
Member

@HarunamiYaki HarunamiYaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of manually pushing each valid maintainer into an array, we can use the map method to simplify the process.

Comment thread src/class/prsReview.ts Outdated
Co-authored-by: Haruyaki <52639021+HarunamiYaki@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@typeslint-cli typeslint-cli Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Muunatic your pull request has been approved by [MAINTAINER]@HarunamiYaki, please type Ready to merge for merging

@typeslint-cli typeslint-cli Bot added Approved Approved PRs and removed Pending Unread Issues/PRs labels Sep 12, 2024
@Muunatic
Copy link
Copy Markdown
Member Author

ready to merge

@typeslint-cli typeslint-cli Bot merged commit 40a81d8 into Typeslint:development Sep 12, 2024
@typeslint-cli
Copy link
Copy Markdown
Contributor

typeslint-cli Bot commented Sep 12, 2024

Merged by Muunatic!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants