Skip to content

refactor: improve tsconfig validation to report missing rules #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
typeslint-cli merged 1 commit into from
Oct 3, 2024
Merged

refactor: improve tsconfig validation to report missing rules #70

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions src/class/prsOpen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,8 +157,18 @@ export default class PullRequestOpen {
path: "tsconfig.json"
}).then(async (res) => {
if ("content" in res.data) {
const textContent:string = res.data.content;
const decodeContent:string = Buffer.from(textContent, "base64").toString("utf-8");
const textContent: string = res.data.content;
const decodeContent: string = Buffer.from(textContent, "base64").toString("utf-8");

const requiredRules = {
noImplicitAny: "\"noImplicitAny\": true",
noImplicitThis: "\"noImplicitThis\": true",
strictFunctionTypes: "\"strictFunctionTypes\": true",
strictNullChecks: "\"strictNullChecks\": true"
};

const missingRules = Object.values(requiredRules).filter((a) => !decodeContent.includes(a));

if (decodeContent.includes("\"noImplicitAny\": true") && decodeContent.includes("\"noImplicitThis\": true") && decodeContent.includes("\"strictFunctionTypes\": true") && decodeContent.includes("\"strictNullChecks\": true")) {
return;
} else {
Expand All @@ -168,7 +178,7 @@ export default class PullRequestOpen {
})
);
const configInvalid = this.context.issue({
body: `[tsconfig](${res.data.html_url}) need [*noImplicitAny*, *noImplicitThis*, *strictFunctionTypes*, *strictNullChecks*] to true value`
body: `[tsconfig](${res.data.html_url}) needs the following rules to be set to true: ${missingRules.join(", ")}`
});
await this.context.octokit.issues.createComment(configInvalid);
}
Expand Down