Skip to content

feat!: migrade to ESM and drop Node v18 support#72

Merged
typeslint-cli[bot] merged 10 commits intoTypeslint:developmentfrom
Muunatic:development
May 10, 2025
Merged

feat!: migrade to ESM and drop Node v18 support#72
typeslint-cli[bot] merged 10 commits intoTypeslint:developmentfrom
Muunatic:development

Conversation

@Muunatic
Copy link
Copy Markdown
Member

@Muunatic Muunatic commented Oct 18, 2024 •
edited
Loading

feat!: migrade to ESM and drop Node v18 support

@Muunatic Muunatic requested a review from HarunamiYaki October 18, 2024 14:56
@typeslint-cli
Copy link
Copy Markdown
Contributor

typeslint-cli Bot commented Oct 18, 2024

Hello @Muunatic Thank you for submitting Pull Request, please wait for next notification after we review your Pull Request

@typeslint-cli typeslint-cli Bot added Pending Unread Issues/PRs lib: Pull Request labels Oct 18, 2024
@Muunatic Muunatic changed the title refactor(prsOpen): using forEach instead of using for loop refactor: using forEach instead of using for loop Oct 18, 2024
@Muunatic Muunatic marked this pull request as ready for review April 10, 2025 01:05
@Muunatic
Copy link
Copy Markdown
Member Author

Muunatic commented Apr 10, 2025

need to review ASAP @HarunamiYaki

HarunamiYaki
HarunamiYaki previously approved these changes Apr 10, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@HarunamiYaki HarunamiYaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

typeslint-cli[bot]
typeslint-cli Bot reviewed Apr 10, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@typeslint-cli typeslint-cli Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Muunatic your pull request has been approved by [MAINTAINER]@HarunamiYaki, please type Ready to merge for merging

@typeslint-cli typeslint-cli Bot added Approved Approved PRs and removed Pending Unread Issues/PRs labels Apr 10, 2025
@typeslint-cli
Copy link
Copy Markdown
Contributor

typeslint-cli Bot commented Apr 14, 2025

PING! . The author has pushed new commits since your last review. please review @Muunatic new commit before merge, thanks!

@typeslint-cli typeslint-cli Bot added CI Failed CI Failed and removed Approved Approved PRs labels Apr 14, 2025
@Muunatic Muunatic changed the title refactor: using forEach instead of using for loop feat!: migrade to ESM and drop Node v18 support Apr 14, 2025
@typeslint-cli
Copy link
Copy Markdown
Contributor

typeslint-cli Bot commented Apr 14, 2025

CI build failed! for more information please review the logs.

@typeslint-cli
Copy link
Copy Markdown
Contributor

typeslint-cli Bot commented Apr 14, 2025

CI build failed! for more information please review the logs.

@Muunatic Muunatic linked an issue Apr 14, 2025 that may be closed by this pull request
Octokit v3 is Vulnerable and Node.js 18 is Reaching EOL #73
Closed
@Muunatic Muunatic added this to the v4.0.0 milestone Apr 14, 2025
@Muunatic
Copy link
Copy Markdown
Member Author

Muunatic commented Apr 14, 2025

seems like typescript v5.3.3 doesn't support ES2023 also we need to bump eslint to v9 to ensure support for the latest typescript version @HarunamiYaki

@typeslint-cli
Copy link
Copy Markdown
Contributor

typeslint-cli Bot commented Apr 16, 2025

CI build failed! for more information please review the logs.

@typeslint-cli typeslint-cli Bot removed the CI Failed CI Failed label Apr 16, 2025
@Muunatic
Copy link
Copy Markdown
Member Author

Muunatic commented May 5, 2025

all set! ready to review @HarunamiYaki

@Muunatic Muunatic requested a review from HarunamiYaki May 5, 2025 17:49
@Muunatic Muunatic added the Major label May 5, 2025
@Muunatic
Copy link
Copy Markdown
Member Author

Muunatic commented May 5, 2025

i haven’t added "type": "module" in package.json yet to avoid potential breakage, a separate PR will follow for that.

HarunamiYaki
HarunamiYaki approved these changes May 8, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@HarunamiYaki HarunamiYaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

typeslint-cli[bot]
typeslint-cli Bot reviewed May 8, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@typeslint-cli typeslint-cli Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Muunatic your pull request has been approved by [MAINTAINER]@HarunamiYaki, please type Ready to merge for merging

@typeslint-cli typeslint-cli Bot added the Approved Approved PRs label May 8, 2025
@Muunatic
Copy link
Copy Markdown
Member Author

Muunatic commented May 10, 2025

ready to merge

@typeslint-cli typeslint-cli Bot merged commit 8afbdd0 into Typeslint:development May 10, 2025
2 checks passed
@typeslint-cli
Copy link
Copy Markdown
Contributor

typeslint-cli Bot commented May 10, 2025

Merged by Muunatic!

@Muunatic Muunatic mentioned this pull request Feb 4, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@typeslint-cli typeslint-cli[bot] typeslint-cli[bot] left review comments

@HarunamiYaki HarunamiYaki HarunamiYaki approved these changes

Assignees

@HarunamiYaki HarunamiYaki

@Muunatic Muunatic

Labels

Approved Approved PRs help wanted lib: Pull Request Major

Projects

None yet

Milestone

v4.0.0

Development

Successfully merging this pull request may close these issues.

Octokit v3 is Vulnerable and Node.js 18 is Reaching EOL

2 participants

@Muunatic @HarunamiYaki