Open
Conversation
Contributor
|
Hi @ellailan, do you have files on your local repository that are not committed to git? For consistency, each project should adhere to the project structure in the template. Namely, the
I haven't gone over the code yet so I'll do that after lunch. |
jonahjlee
requested changes
Feb 14, 2026
Contributor
jonahjlee
left a comment
There was a problem hiding this comment.
Thanks Ella! I really appreciate the inline Markdown documentation!
Some notes:
- Try to avoid 'magic numbers' in your code, i.e., constants whose origin is not obvious to the reader. Instead, assigning them to a descriptive variable name helps a reader understand what they mean.
meters_per_deg_lat = 111132.954 - 559.822 * math.cos(2 * math.radians(center_lat))
meters_per_deg_lon = 111412.84 * math.cos(math.radians(center_lat))- One of the plots seems to be missing labels
Looks great otherwise! When you have finalized the notebook, please create a .pdf file and store it in the localization_with_acceleration/results directory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What's New
This project includes a Juypter notebook with a method to localize data from 2025 FSGP. We investigate the success of a model that localizes acceleration by calculating radius of curvature and graphing it around the track.