Skip to content

Localization with Acceleration#25

Open
ellailan wants to merge 10 commits intomainfrom
localization_with_acceleration
Open

Localization with Acceleration#25
ellailan wants to merge 10 commits intomainfrom
localization_with_acceleration

Conversation

@ellailan
Copy link

What's New

This project includes a Juypter notebook with a method to localize data from 2025 FSGP. We investigate the success of a model that localizes acceleration by calculating radius of curvature and graphing it around the track.

@ellailan ellailan requested a review from jonahjlee February 14, 2026 19:45
@jonahjlee
Copy link
Contributor

jonahjlee commented Feb 14, 2026

Hi @ellailan, do you have files on your local repository that are not committed to git? For consistency, each project should adhere to the project structure in the template. Namely, the pyproject.toml and uv.lock files should be present to allow people to install the dependencies they need.

image

I haven't gone over the code yet so I'll do that after lunch.

Copy link
Contributor

@jonahjlee jonahjlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ella! I really appreciate the inline Markdown documentation!

Some notes:

  1. Try to avoid 'magic numbers' in your code, i.e., constants whose origin is not obvious to the reader. Instead, assigning them to a descriptive variable name helps a reader understand what they mean.
meters_per_deg_lat = 111132.954 - 559.822 * math.cos(2 * math.radians(center_lat))
meters_per_deg_lon = 111412.84 * math.cos(math.radians(center_lat))
  1. One of the plots seems to be missing labels
Image

Looks great otherwise! When you have finalized the notebook, please create a .pdf file and store it in the localization_with_acceleration/results directory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments