Skip to content

[FIX]: Fix Solcast Datetime#28

Merged
joshuaRiefman merged 2 commits intomainfrom
fix_solcast_datetime
May 24, 2025
Merged

[FIX]: Fix Solcast Datetime#28
joshuaRiefman merged 2 commits intomainfrom
fix_solcast_datetime

Conversation

@jonahjlee
Copy link
Contributor

[FIX]: Fix Solcast Datetime

  • All Tests Succeeded
  • Module Documentation
  • Method/Class/Function Documentation
  • Documentation Correctly Builds
  • Sufficent Test Code Coverage
  • Pull Request Completed

Bugfixes

Fix: x_axis in _solcast.py was not working for datetime type:

time_axis: NDArray = np.fromiter(map(time_parser, weather_df.index), dtype=float)
                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: float() argument must be a string or a real number, not 'datetime.datetime'

Added test for datetime x-axis.

@codecov
Copy link

codecov bot commented May 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@joshuaRiefman joshuaRiefman changed the title Fix solcast datetime [FIX]: Fix Solcast Datetime May 24, 2025
@joshuaRiefman joshuaRiefman self-requested a review May 24, 2025 21:03
@joshuaRiefman joshuaRiefman merged commit 60b41c8 into main May 24, 2025
4 checks passed
@joshuaRiefman joshuaRiefman deleted the fix_solcast_datetime branch May 24, 2025 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments