Hungarian Algorithm Optimizations#3602
Draft
Andrewyx wants to merge 2 commits intoUBC-Thunderbots:masterfrom
Draft
Hungarian Algorithm Optimizations#3602Andrewyx wants to merge 2 commits intoUBC-Thunderbots:masterfrom
Andrewyx wants to merge 2 commits intoUBC-Thunderbots:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, the Tactics are assigned to robots using the Hungarian Algorithm which optimizes the results of the cost function matrix which dictates the potential cost of each robot using each tactic. This algorithm is unfortunately very expensive, with asymptotic runtime of$O(n^4)$ and with some modifications $O(n^3)$ . Hence, an alternative algorithm could provide more efficient execution.
The Jonker-Volgenant algorithm presents itself as an$O(n^3)$ linear assignment problem algorithm, which on average runs much faster than $O(n^3)$ . This PR tries to apply this algorithm in replacement for the current Hungarian algorithm
Jonker, R., Volgenant, A. A shortest augmenting path algorithm for dense and sparse linear assignment problems. Computing 38, 325–340 (1987). https://doi.org/10.1007/BF02278710
Testing Done
Resolved Issues
Length Justification and Key Files to Review
Review Checklist
It is the reviewers responsibility to also make sure every item here has been covered
.hfile) should have a javadoc style comment at the start of them. For examples, see the functions defined inthunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.TODO(or similar) statements should either be completed or associated with a github issue