remove all hardware_challenge_plays and adjust build#3612
Open
StarrryNight wants to merge 1 commit intoUBC-Thunderbots:masterfrom
Open
remove all hardware_challenge_plays and adjust build#3612StarrryNight wants to merge 1 commit intoUBC-Thunderbots:masterfrom
StarrryNight wants to merge 1 commit intoUBC-Thunderbots:masterfrom
Conversation
StarrryNight
requested review from
Andrewyx,
sauravbanna and
williamckha
as code owners
StarrryNight
force-pushed
the
remove_hardware_challenge_plays#3611
branch
from
617c02b to
cc1a5de
Compare
Contributor
|
nit: link to the task detailing removal of coroutines |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#3611 , part of #2359
Remove all hardware_challenge_plays
They were used in the virtual robocup 2021. These plays are no longer used and lots of them are not even implemented fully.
Testing Done
play factory test passes and all_plays build
Resolved Issues
#3611
Length Justification and Key Files to Review
Review Checklist
It is the reviewers responsibility to also make sure every item here has been covered
.hfile) should have a javadoc style comment at the start of them. For examples, see the functions defined inthunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.TODO(or similar) statements should either be completed or associated with a github issue