Conversation
Member
|
Personally, I'd vote for consistency 🤷 |
Member
|
I'm 🤷 here. Do we want to recommend pre-commit.ci over running a linting job by ourselves in Actions? If so we should add that to the docs because it's a different to what we're recommending currently. There's also the question of (legitimately) private RSE projects which this cookie-cutter would then be less useful for. |
Member
Member
Author
|
👍 I buy the consistency between free/private repositories. I'll disable pre-commit.ci on this repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

I set up https://pre-commit.ci/ to run pre-commit on the repository. The advantage of this over github actions is you can leave a comment that says "pre-commit.ci autofix" on the PR, and it will push a commit that fixes any issues that can be automatically fixed.
I left the GH actions job that lints the template after a package is generated, as I don't think there's a way to replace that.