Skip to content

Use pre-commit.ci for linting repository#196

Closed
dstansby wants to merge 1 commit intomainfrom
pcr-ci
Closed

Use pre-commit.ci for linting repository#196
dstansby wants to merge 1 commit intomainfrom
pcr-ci

Conversation

@dstansby
Copy link
Member

I set up https://pre-commit.ci/ to run pre-commit on the repository. The advantage of this over github actions is you can leave a comment that says "pre-commit.ci autofix" on the PR, and it will push a commit that fixes any issues that can be automatically fixed.

I left the GH actions job that lints the template after a package is generated, as I don't think there's a way to replace that.

@paddyroddy
Copy link
Member

Personally, I'd vote for consistency 🤷

@samcunliffe
Copy link
Member

samcunliffe commented Nov 5, 2023

I'm 🤷 here. Do we want to recommend pre-commit.ci over running a linting job by ourselves in Actions? If so we should add that to the docs because it's a different to what we're recommending currently.

There's also the question of (legitimately) private RSE projects which this cookie-cutter would then be less useful for.

@paddyroddy
Copy link
Member

There's also the question of (legitimately) private RSE projects which this cookie-cutter would then be less useful for.

I would for one approach for public & private. Unfortunately, many ARC projects are still private.
CI pricing

@dstansby
Copy link
Member Author

dstansby commented Nov 6, 2023

👍 I buy the consistency between free/private repositories. I'll disable pre-commit.ci on this repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants