Skip to content

Exclude lock files and don't just write changes #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
paddyroddy wants to merge 5 commits into from
Closed

Exclude lock files and don't just write changes #207

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6a96a79
Exclude lock files and don't just write changes
paddyroddy Oct 25, 2023
44a5a06
Update lock file
paddyroddy Oct 25, 2023
1c4357a
More args into own line
paddyroddy Oct 25, 2023
6e2afdc
Add `codespell` in nested `pre-commit`
paddyroddy Oct 25, 2023
88c91fb
Merge branch 'main' into fix-codespell-update-lock
paddyroddy Oct 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,15 +6,17 @@ repos:
rev: v0.1.2
hooks:
- id: ruff
args: ["--config", "pyproject.toml"]
args:
- --config=pyproject.toml
exclude: "{{cookiecutter.project_slug}}/src/{{cookiecutter.package_name}}"
- id: ruff-format
args: ["--config", "pyproject.toml"]
args:
- --config=pyproject.toml
- repo: https://github.com/codespell-project/codespell
rev: v2.2.6
hooks:
- id: codespell
args: [--write-changes]
Copy link
Member Author

@paddyroddy paddyroddy Oct 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samcunliffe they key is to just not have this line. I've used it in UCL-MIRSG repos recently to great effect.

exclude: ".lock$"
- repo: https://github.com/Lucas-C/pre-commit-hooks
rev: v1.5.4
hooks:
Expand All @@ -28,8 +30,10 @@ repos:
rev: v1.6.1
hooks:
- id: mypy
args: [--config-file, pyproject.toml]
additional_dependencies: ["pytest"]
args:
- --config-file=pyproject.toml
additional_dependencies:
- pytest
exclude: "{{cookiecutter.project_slug}}/src/{{cookiecutter.package_name}}"
- repo: https://github.com/pre-commit/mirrors-prettier
rev: v3.0.3
Expand All @@ -44,7 +48,8 @@ repos:
- id: check-merge-conflict
- id: end-of-file-fixer
- id: mixed-line-ending
args: [--fix=lf]
args:
- --fix=lf
- id: trailing-whitespace
- repo: https://github.com/renovatebot/pre-commit-hooks
rev: 37.33.0
Expand Down
20 changes: 12 additions & 8 deletions docs/Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,10 @@ GEM
eventmachine (>= 0.12.9)
http_parser.rb (~> 0)
eventmachine (1.2.7)
ffi (1.16.2)
ffi (1.16.3)
forwardable-extended (2.6.0)
google-protobuf (3.24.4-arm64-darwin)
google-protobuf (3.24.4-x86_64-linux)
http_parser.rb (0.8.0)
i18n (1.14.1)
concurrent-ruby (~> 1.0)
Expand All @@ -32,8 +34,8 @@ GEM
webrick (~> 1.7)
jekyll-include-cache (0.2.1)
jekyll (>= 3.7, < 5.0)
jekyll-sass-converter (2.2.0)
sassc (> 2.0.1, < 3.0)
jekyll-sass-converter (3.0.0)
sass-embedded (~> 1.54)
jekyll-seo-tag (2.8.0)
jekyll (>= 3.8, < 5.0)
jekyll-watch (2.2.1)
Expand All @@ -60,13 +62,15 @@ GEM
rb-inotify (0.10.1)
ffi (~> 1.0)
rexml (3.2.6)
rouge (4.1.3)
rouge (4.2.0)
safe_yaml (1.0.5)
sassc (2.4.0)
ffi (~> 1.9)
sass-embedded (1.69.4-arm64-darwin)
google-protobuf (~> 3.23)
sass-embedded (1.69.4-x86_64-linux-gnu)
google-protobuf (~> 3.23)
terminal-table (3.0.2)
unicode-display_width (>= 1.1.1, < 3)
unicode-display_width (2.4.2)
unicode-display_width (2.5.0)
webrick (1.8.1)

PLATFORMS
Expand All @@ -78,4 +82,4 @@ DEPENDENCIES
just-the-docs (= 0.6.2)

BUNDLED WITH
2.3.9
2.4.21
8 changes: 6 additions & 2 deletions {{cookiecutter.project_slug}}/.pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@ repos:
hooks:
- id: ruff
- id: ruff-format
- repo: https://github.com/codespell-project/codespell
rev: v2.2.6
hooks:
- id: codespell
- repo: https://github.com/Lucas-C/pre-commit-hooks
rev: v1.5.4
hooks:
Expand All @@ -16,7 +20,6 @@ repos:
rev: v1.6.1
hooks:
- id: mypy
additional_dependencies: [numpy, pydantic]
- repo: https://github.com/pre-commit/mirrors-prettier
rev: v3.0.3
hooks:
Expand All @@ -30,5 +33,6 @@ repos:
- id: check-toml
- id: end-of-file-fixer
- id: mixed-line-ending
args: [--fix=lf]
args:
- --fix=lf
- id: trailing-whitespace