Merged
Conversation
dstansby
reviewed
Oct 26, 2023
dstansby
reviewed
Oct 26, 2023
Member
dstansby
left a comment
dstansby
left a comment
There was a problem hiding this comment.
I'm 👍 to keeping write-changes, as it makes life easier and in my experience the error rate of codespell is low enough that stuff can be caught in code review. So I won't block, but I won't explicitly approve either.
paddyroddy
changed the title
write-changes as it is dangerous & ignore lock fileswrite-changes as it is dangerous
This was referenced Oct 26, 2023
Member
|
In my opinion, we should also remove it from the tooling repo's pre-commit config. |
Member
Author
|
Keeping @samcunliffe on board |
samcunliffe
approved these changes
Oct 27, 2023
dstansby
approved these changes
Oct 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suggestion to split #207 up