Closed
Conversation
paddyroddy
requested review from
matt-graham,
mxochicale,
ruaridhg,
samcunliffe and
sfmig
Member
|
I started reading this, and have some pending in-line comments, but got a bit bored since it's very verbose... I worry that others will not bother reading all of this either. I like the intent though, so wonder if there any shorter versions out there? |
Member
|
I would rather word it ourselves and pull out the contributing part of README. Do you want me to take a stab at this? |
Member
Author
Yes plox |
Member
|
☝️ I'll start from scratch. |
Member
Author
Can't wait xox |
samcunliffe
added a commit
that referenced
this pull request
Jan 23, 2024
> [!NOTE] > Reviewers: > Please do double-check that what I've written doesn't break the flow of README.md and that I've kept the tone encouraging. * Solves (the rest of?) #245 * Supersedes #252 (although as I write this comment, I realise there're significantly fewer ❤️ emoji). --------- Co-authored-by: Matt Graham <matthew.m.graham@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated from here https://bttger.github.io/contributing-gen-web