-
Notifications
You must be signed in to change notification settings - Fork 9
Sam's attempt at a welcoming CONTRIBUTING file. #278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| This template and our [recommendation pages][website] were made by [research | ||
| software engineers] at [UCL's Centre for Advanced Research Computing][UCL ARC]. | ||
| We made it with research software projects in mind, but whoever you are, we hope | ||
| you find this useful! | ||
|
|
||
| We are actively encouraging users to ask questions and start discussions in the | ||
| [discussions tab] of this repository. Does something seem like it's broken? | ||
| Please go ahead and [open an issue]! | ||
|
|
||
| The [website] pages are open to contributions but they will need to be reviewed | ||
| by a member or associate member of ARC. We might be slow to approve new tool | ||
| suggestions (since we'll probably want to discuss them first) but don't let that | ||
| put you off creating an issue. | ||
|
|
||
| ## Development workflow | ||
|
|
||
| To contribute a change, please: | ||
|
|
||
| 1. Create a new branch (or fork if you're not in [@UCL-ARC/collaborations]). | ||
| 2. Modify an existing page, create a new one, or tweak the template. | ||
| a. Run [pre-commit](https://pre-commit.com) which will lint your changes. | ||
| b. Check the tests pass if you modified the template (`pytest -s`). | ||
| 3. Open a _pull request_ (PR) with changes. | ||
| 4. Ask someone who did not contribute to the PR from [@UCL-ARC/collaborations] | ||
| to review it. | ||
| 5. If approved with no comments, then the reviewer will merge the PR. | ||
| 6. If changes are requested, the PR author should address the comments, and then | ||
| ask for review again. | ||
|
|
||
| <!-- links here --> | ||
|
|
||
| <!-- prettier-ignore-start --> | ||
| [website]: https://github-pages.arc.ucl.ac.uk/python-tooling | ||
| [UCL ARC]: https://ucl.ac.uk/arc | ||
| [open an issue]: https://github.com/UCL-ARC/python-tooling/issues/new/choose | ||
| [Discussions tab]: https://github.com/UCL-ARC/python-tooling/discussions | ||
| [Research software engineers]: https://society-rse.org/about/history | ||
| [@UCL-ARC/collaborations]: https://github.com/orgs/UCL-ARC/teams/collaborations | ||
| <!-- prettier-ignore-end --> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.