Merged
Conversation
Member
dstansby
commented
Mar 25, 2024
dstansby
commented
- Don't put an acronym in table of contents
- Note that GH Actions also available for private repos for free
- Link to testing page for test coverage collection recommendation
- Add a details box explaining why there are two 🟢 coverage hosting tools
samcunliffe
requested changes
Mar 25, 2024
paddyroddy
reviewed
Mar 25, 2024
| <details> | ||
| <summary> 🟢 explanation</summary> | ||
| We have many projects using github CI, it's both convenient and works well. It's become the standard. Also, note that it's free for public repos. | ||
| We have many projects using GitHub CI and, it has good integration with GitHub itself, and is free for public repositories (with limited free monthly minutes for private repositories). |
Member
There was a problem hiding this comment.
Seeing as this is the first time we are using CI, should we define it?
Suggested change
| We have many projects using GitHub CI and, it has good integration with GitHub itself, and is free for public repositories (with limited free monthly minutes for private repositories). | |
| We have many projects using GitHub continuous integration (CI) and, it has good integration with GitHub itself, and is free for public repositories (with limited free monthly minutes for private repositories). |
Member
There was a problem hiding this comment.
Would be nice if this page could be wrapped to 80 chars, in keeping with other pages
Member
Author
There was a problem hiding this comment.
I think if we want to enforce wrap to 80 it would be best to do via a pre-commit hook instead of having to manually edit?
Member
Author
There was a problem hiding this comment.
Thanks for catching the acronym - I edited the title of this section instead since CI is such a common acronym.
Member
There was a problem hiding this comment.
Sure, it's slightly tricky though as links can go over - and tables. I like markdownlint.
Co-authored-by: Sam Cunliffe <samcunliffe@users.noreply.github.com>
samcunliffe
approved these changes
Mar 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.