Adding longer prompts for all cookiecutter options#380
Merged
matt-graham merged 6 commits intomainfrom Jun 5, 2024
Merged
Conversation
paddyroddy
approved these changes
Jun 4, 2024
Member
paddyroddy
left a comment
There was a problem hiding this comment.
I think this is a great idea. Agree on your second point, we probably want a character limit on them.
Collaborator
Author
|
I've had a go at shortening the prompts - maximum character length is now 65, and renders as |
dstansby
approved these changes
Jun 5, 2024
Member
dstansby
left a comment
There was a problem hiding this comment.
Some minor suggestions, but looks 👍 overall!
Co-authored-by: David Stansby <dstansby@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #296 and fixes #305
Adds longer human-readable prompts for all cookiecutter template options using the
promptsfield incookiecutter.json(we already had a prompt fordeploy_docs_to_github_pagesoption from #319).Questions
author_emailare unnecessary?With current prompts, creating a new packages with default options renders as