Two reviewers for "opinionated" changes.#473
Merged
samcunliffe merged 8 commits intomainfrom Nov 6, 2024
Merged
Conversation
paddyroddy
added
documentation
dstansby
previously requested changes
Oct 22, 2024
samcunliffe
changed the title
matt-graham
reviewed
Nov 4, 2024
matt-graham
approved these changes
Nov 4, 2024
Collaborator
matt-graham
left a comment
matt-graham
left a comment
There was a problem hiding this comment.
Seems all reasonable to me - have made a small suggestion to change one occurence of opinion changes to opinionated changes
Co-authored-by: Matt Graham <matthew.m.graham@gmail.com>
samcunliffe
dismissed
dstansby’s stale review
Replaced "controversial" with "opinonated"
samcunliffe
deleted the
350-move-to-having-two-reviewers-for-pull-requests
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following discussion, this would be a compromise resolution to #350.
As this could be controversial, I will add two reviewers. (cc @dstansby but I don't want to disturb your holiday)