Change license.file to license-files + SPDX-compliance#528
Conversation
I encountered this issue when making a release astro-informatics/sleplet#451
matt-graham
left a comment
There was a problem hiding this comment.
Looks good to me.
In case helpful to anyone understanding why this change is required, relevant part of Python Packaging User Guide documentation says that
As per PEP 639 licenses should be declared with two fields:
licenseis an SPDX license expression consisting of one or more license identifiers.license-filesis a list of license file glob patterns.A previous PEP had specified license to be a table with a file or a text key, this format is now deprecated.
matt-graham
left a comment
There was a problem hiding this comment.
Actually reading the above linked documentation a bit more carefully I think we want to specify both license and license-files fields?
Co-authored-by: Matt Graham <matthew.m.graham@gmail.com>
Co-authored-by: Matt Graham <matthew.m.graham@gmail.com>
|
https://stackoverflow.com is currently down |
I glanced over it initially, but yeah I think you are right, it does want both. It didn't error with just one, but did with the use of the old |
license.file to license-fileslicense.file to license-files + SPDX-compliance
matt-graham
left a comment
There was a problem hiding this comment.
Thanks for updating, looks all good to me.
I encountered this issue when making a release astro-informatics/sleplet#451. Also, make
BSD-3SPDX-compliant.