fix: improve contrast for all links, button and label text#545
fix: improve contrast for all links, button and label text#545paddyroddy merged 3 commits intoUCL-ARC:mainfrom
Conversation
|
@samcunliffe, thanks for merging main into feature branch! |
@cuteshaun, I'm sorry about the unfriendly contributor experience! Our CI was a bit misconfigured ❌❌. |
|
Screencast: first tab is these changes, second tab is the current deployed version. Screen.Recording.2025-06-10.at.07.10.07.movLooks really nice! Also improves the traffic lights' colour contrast. |
samcunliffe
left a comment
There was a problem hiding this comment.
Yeah, thanks again for the really nice and fast contribution!
Are you planning to attempt to get these changes in upstream? Let us know and we'll all thumbs-up your PR(s)!
| $blue-400: #4da6ff; | ||
| $green-700: #00755c; | ||
| $red-600: #d13c3c; |
Haha, thanks, really appreciate that! When you say “upstream,” do you mean the original repository for just the docs theme? |
paddyroddy
left a comment
There was a problem hiding this comment.
This is a really nice piece of work
| const theme = localStorage.getItem("theme") === "dark" ? "dark" : "light"; | ||
| jtd.setTheme(theme); | ||
| setHtmlThemeAttr(theme); | ||
| toggleDarkMode.textContent = theme === "dark" ? "☼" : "☾"; |
Yes, exactly. There are a few PRs open, but I didn't spot anything specifically improving the accessibility (there are issues but no solutions afai can see). |


This PR improves dark mode accessibility to meet the minimum contrast ratio of 4.5:1.
Issues
Changes
Closes #535
Verified links contrast with the WCAG contrast checker tool