Merged
Conversation
Member
melferink
commented
Mar 24, 2022
melferink
commented
- Includes Modules for GATK 4.2.1.0
- Including gzip option for output VCF files
…ules into feature/gatk4.2
lvanoijen
requested changes
Apr 5, 2022
lvanoijen
left a comment
lvanoijen
left a comment
There was a problem hiding this comment.
Besides the small typo in SelectVariants.nf it is looking ok.
There is also an improvement you can make looking at the coding guidelines (wiki):
-Clear code: Avoid lines longer than 127 characters. -> split long lines in the output and script sections
lvanoijen
approved these changes
Apr 22, 2022
sawibo
approved these changes
Apr 22, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.