Conversation
Now only adding "/opt/openFrameworksArduino/include/" to the include directory instead of "/opt/openFrameworksArduino/include/openFrameworksArduino". This means you need to "#include <openFrameworksArduino/ofArduino.h>" instead of just "#include <ofArduino.h>"
This was causing problems when doing it this way for Boost::log in umrt-arm-firmware-lib, so propagating best practices
Author
|
As with PR #2 the version assertion is failing because when I made that workflow I assumed all repos were using "main" as the default branch. At this point I am still not interested in investing the time to fix that, seeing as this repo is the only one of our repos I know of affected by that problem and this repo is not expected to be changed again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous CMake config generated a static library package, but we were not generating the CMake Config/ConfigVersion files needed for find_package to discover the library. This adds that and prompted some improvement of the CMakeLists.