You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Nice work Aryan! The only issue I see is that you made your changes on the main branch. Usually we work off of the dev branch as that has the latest updates (like the new UI).
To fix that, it might be best to make a new branch based on dev, copy your changes over (you may have to tweak your code since dev is a little different), and then create a new PR for that branch.
Nice work Aryan! The only issue I see is that you made your changes on the main branch. Usually we work off of the dev branch as that has the latest updates (like the new UI).
To fix that, it might be best to make a new branch based on dev, copy your changes over (you may have to tweak your code since dev is a little different), and then create a new PR for that branch.
Thanks! I rebased the changes onto the dev branch and opened a new PR based on dev. Let me know if you'd like any adjustments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for manually sending ACK messages from the SOTI CLI.
ack=true/falseoption to thesendcommandThis allows testing of satellite behavior under unexpected ACK scenarios.