-
Notifications
You must be signed in to change notification settings - Fork 99
Updated LBL links #1832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Updated LBL links #1832
Conversation
I think these are what will be the new links. They might not yet be ready, so I will undraft this when they are.
|
Question for @exoticDFT and @crd477: The URL check is passing for these new links, even tho the one for my group (Scientific Software Engineering) isn't actually live yet. That is what the link will be once it goes live, probably in less than a week. The URL check failure on the zenodo doi, is another thing entirely. Are you ok with merging this as is, knowing 1 link it fixed and 1 is not yet working correctly but will be soon? |
|
Yes, it's OK with me to merge as-is. |
crd477
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops, forgot to do the formal review step. This looks good to me except that instead of being a WordPress landing page, the first link now appears to be password protected.
Ugh, yes, I know. I'm trying to get that page published properly. What is rather frustrating is they have listened to my complaints about breaking the old links by setting up redirects to the new pages. Which of course means as soon as the new links I have here work, so will the old ones via redirects. I still think this PR is worth merging as at least these are more "direct" links now. |
|
I believe the new LBL links are fully working now. And, to make this whole exercise even more frustrating, the old links have redirects now that point to these new links! |
Description
I think these are what will be the new links. They might not yet be ready, so I will undraft this when they are.
Checklist:
When you are ready for a technical review/merge, post the for the link for the PR in the US-RSE Slack (#website) to ask for reviewers.