Merged
Conversation
elwincheng
force-pushed
the
elwin_container_structure_test
branch
from
12455f2 to
e33009d
Compare
elwincheng
changed the title
KCui0327
approved these changes
Jul 13, 2025
ambroseling
approved these changes
Jul 29, 2025
|
|
||
| for image in "${images[@]}"; do | ||
| cd $path/$image | ||
| sh ./run_test.sh $image |
Contributor
There was a problem hiding this comment.
is there maybe a way to add error handling here or log if the process did not exit gracefully we just notify the test runners, but this is bit of nitpick
KCui0327
pushed a commit
that referenced
this pull request
Aug 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
todo: add config.yaml for cpu and rocm images.