Open
Conversation
bkellogg
commented
Feb 8, 2019
| node_modules/ | ||
| .vscode/ | ||
| .idea/ | ||
| .DS_Store |
Author
There was a problem hiding this comment.
It also may be prudent to add these lines to your global gitignore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
node_modulesandpackage-lock.jsonwhich are not needed in a static website..DS_Storewhich is a MacOS file for storing attributes in a folder. This is not needed here..gitignorewhich should prevent a few things from coming back into the repo.index.htmlon a few pages.NGINX, the webserver that serves the site on https://winfo.ischool.uw.edu, is case sensitive by default. This caused a few images to not load, but if the extensions are changed through the element inspector they will load correctly. For example, take a look at the
OUR MISSIONsection on the site index. This PR should fix all of these issues. Just something to keep in mind for the future :)Additionally, the auto deploy server is up and running again and has been updated to be more tolerant of server restarts and the like. The site has been updated to the latest git sha on
master. It should automatically restart if the server restarts, but I can show someone how to restart it as well as how it works so hopefully it'll become less magical and easy to be managed or improved upon in the future. Let me know!@sburd36 @huibrm