Skip to content

Conversation

@rajeeja
Copy link
Contributor

@rajeeja rajeeja commented Mar 19, 2025

algorithm works with cartesian coords only, towards #1176

@rajeeja rajeeja self-assigned this Mar 19, 2025
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@rajeeja rajeeja changed the title Draft: API changes for area correction DRAFT: API changes for area correction Mar 24, 2025
philipc2 and others added 4 commits March 31, 2025 22:33
updates:
- [github.com/astral-sh/ruff-pre-commit: v0.11.0 → v0.11.2](astral-sh/ruff-pre-commit@v0.11.0...v0.11.2)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Philip Chmielowiec <67855069+philipc2@users.noreply.github.com>
Bumps [actions/setup-python](https://github.com/actions/setup-python) from 5.4.0 to 5.5.0.
- [Release notes](https://github.com/actions/setup-python/releases)
- [Commits](actions/setup-python@v5.4.0...v5.5.0)

---
updated-dependencies:
- dependency-name: actions/setup-python
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@philipc2 philipc2 changed the title DRAFT: API changes for area correction Update Face Area API to only use Cartesian Coordinates Apr 23, 2025
Copy link
Member

@philipc2 philipc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on this!

@philipc2 philipc2 linked an issue Apr 23, 2025 that may be closed by this pull request
@philipc2 philipc2 merged commit 4fe0c69 into main Apr 23, 2025
20 checks passed
@erogluorhan erogluorhan deleted the rajeeja/cleanup_area_correction branch September 26, 2025 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add flag for area correction

3 participants